Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Canary recipe - wrapper over the SocketCAN API #14011

Merged
merged 25 commits into from
Nov 29, 2022

Conversation

klimkin
Copy link
Contributor

@klimkin klimkin commented Nov 3, 2022

Specify library name and version: canary/1.0.0

Canary is a thin, C++11 wrapper over the SocketCAN API in Linux, which enables communication over CAN bus using idioms from the Boost.ASIO and ASIO libraries.

https://github.com/djarek/canary


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all this looks really good -- just a a bunch of minor comments cleaning up some details

for ex the test package was missing the layout

but super good work

recipes/canary/all/conandata.yml Outdated Show resolved Hide resolved
recipes/canary/all/conanfile.py Outdated Show resolved Hide resolved
recipes/canary/all/conanfile.py Outdated Show resolved Hide resolved
recipes/canary/all/conanfile.py Outdated Show resolved Hide resolved
recipes/canary/all/conanfile.py Show resolved Hide resolved
recipes/canary/all/conanfile.py Outdated Show resolved Hide resolved
recipes/canary/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/canary/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/canary/config.yml Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 23 (00febeed6b1a3f15f70ea2e47b62b4f812043c1c):

  • canary/v1@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 7113f33 into conan-io:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants