Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sail: Use CMAKE_TRY_COMPILE_CONFIGURATION for all compilers #25822

Closed
wants to merge 2 commits into from
Closed

sail: Use CMAKE_TRY_COMPILE_CONFIGURATION for all compilers #25822

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7bc6a2
sail: Use CMAKE_TRY_COMPILE_CONFIGURATION for all compilers
HappySeaFox Nov 4, 2024
6b73e03
Add missing package_type
AbrilRBS Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions recipes/sail/all/conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ class SAILConan(ConanFile):
topics = ( "image", "encoding", "decoding", "graphics" )
license = "MIT"
settings = "os", "arch", "compiler", "build_type"
package_type = "library"
options = {
"shared": [True, False],
"fPIC": [True, False],
Expand Down Expand Up @@ -109,8 +110,7 @@ def generate(self):
tc.variables["SAIL_INSTALL_PDB"] = False
tc.variables["SAIL_THREAD_SAFE"] = self.options.thread_safe
# TODO: Remove after fixing https://github.com/conan-io/conan/issues/12012
if is_msvc(self):
tc.cache_variables["CMAKE_TRY_COMPILE_CONFIGURATION"] = str(self.settings.build_type)
tc.cache_variables["CMAKE_TRY_COMPILE_CONFIGURATION"] = str(self.settings.build_type)
tc.generate()

deps = CMakeDeps(self)
Expand Down