-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fswatch: add package #25895
fswatch: add package #25895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking the time to create the PR, we appreciate it!
I have some comments, specially regarding the chosen prerelease version scheme, but otherwise the recipe looks fine :)
recipes/fswatch/all/conandata.yml
Outdated
"1.17.1": | ||
url: "https://github.com/emcrisostomo/fswatch/archive/refs/tags/1.17.1.zip" | ||
sha256: "2a2be51807a7138cf50b327a9de29b96892dd357ab3142a5b4e36cb380ee4470" | ||
"1.17.1-36": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this version, as per semver semantics, would come before 1.17.1
, that is, 1.17.1-36 < 1.17.1
, which I don't think is the intention here!
We should clarify if upstream is expecting to release a new version soon with this fix, else we'll need to roll our own schema for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, you're absolutely right. Since the latest commit was two years ago and the repository is more or less in hibernation mode, I don't think there will be a tag or release soon. Is there the possibility to refer to a specific commit without the need to assign it a version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! We can set this version to 1.17.1.cci.YYYYMMDD
for the date of the latest commit, which is our way of indicating that the version comes from a specific commit and is not tagged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I adapted the 1.17.1-36
version according to the proposed scheme and removed the (faulty) 1.17.1 version.
Thanks for your review - very appreciated. I have some questions regarding the failing builds:
|
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
@winternet I did few changes your PR, fixing some previous errors.
In case a contributor has no time or access to a platform, it should not be a blocker, we can merge the partial recipe and add messages and invalid configuration asking to future support.
I use Linux as well (BTW I use Arch), in case you are having trouble to reproduce the same result, I would recommend using the same docker image as used by the CI:
|
Summary
Add fswatch package.
Motivation
Make fswatch available to the community.
Details
While the latest release version is 1.17.1, there is a documented known issue which leads to the version 1.17.1-36