-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cpr #3727
Update cpr #3727
Conversation
I detected other pull requests that are modifying cpr recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Some configurations of 'cpr/1.3.0' failed in build 1 (
|
Hm, the other CPR PR failed on macs on v1.3.0 as well. Looks like an OpenSSL config issue, but got no idea what to do about it, if something has to be done at all. Purely a missing package from what I can tell at least, which isn't too bad Ah, no, it's related to the linked PR. It's unfortunately stale, might take a look at that later |
Failure in build 2 (
|
Oh, this actually doesn't have anything to do with the deprecation. libcurl has only been built with darwinssl in the Mac configurations. |
All green in build 3 (
|
Reading the other PR I am not sure this is the best solution : thinking: maybe just leave the check and keep the throw for it to pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Specify library name and version: cpr/1.5.2
conan-center hook activated.
Fixes #3321
Admittedly, I have no idea whether this is close to working. Works on my Linux machine, but that's about it. The reason behind the error listed in #3470 is that the patch is out of date - that part of the patch is easy to fix. Minor changes in the CMake caused curl-global-scope.patch to be incorrect. I've bumped that, and cleared out
find_package(CURL COMPONENTS ...)
as this caused problems locally. I have no idea whether or not this makes sense or even should be done, as I don't really use CMake myself - improvements to the patch are welcome. Found the fix by comparing it to an old version of CPR, which didn't containCOMPONENTS
in thefind_package
.