Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change border radius api #160

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Change border radius api #160

merged 2 commits into from
Jan 19, 2024

Conversation

tilucasoli
Copy link
Collaborator

@tilucasoli tilucasoli commented Jan 18, 2024 •
edited
Loading

Describe your changes

  • Modify the API to separate the border and borderRadius properties

Type of change

  • API change (breaking change which modify a functionality)
  • Docs (changes to the documentation)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@tilucasoli tilucasoli marked this pull request as ready for review January 18, 2024 21:47
@tilucasoli tilucasoli requested a review from leoafarias January 18, 2024 21:47
leoafarias
leoafarias approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias leoafarias merged commit b8de429 into main Jan 19, 2024
2 checks passed
@tilucasoli tilucasoli deleted the feature/change-border-radius-api branch July 12, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoafarias leoafarias leoafarias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tilucasoli @leoafarias