Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new of method for spacing #162

Merged
merged 9 commits into from
Jan 25, 2024

Conversation

tilucasoli
Copy link
Collaborator

@tilucasoli tilucasoli commented Jan 22, 2024

Describe your changes

  • Create method of for space token to be possible to use box.padding.horizontal.of($space.small);
  • Create method of for radius token now you can box.borderRadius.of($space.small);
  • Create $breakpoint constant;
  • Create a new test case to validate theme;

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@tilucasoli tilucasoli requested a review from leoafarias January 24, 2024 17:59
Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2024 0:17am

@tilucasoli tilucasoli marked this pull request as ready for review January 25, 2024 00:18
@tilucasoli tilucasoli marked this pull request as draft January 25, 2024 00:18
@tilucasoli tilucasoli marked this pull request as ready for review January 25, 2024 00:18
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias leoafarias merged commit 6dd766b into main Jan 25, 2024
4 checks passed
@leoafarias leoafarias deleted the feat/create-of-methods-for-design-tokens branch January 25, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants