-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create StyledImage #185
Create StyledImage #185
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good!
|
||
BlendModeUtility<ImageSpecAttribute> get blendMode { | ||
return BlendModeUtility((blendMode) => _only(blendMode: blendMode)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add a call()
method. One to keep in mind, though, is the call() method takes the actual Flutter core classes, not Dtos, if they exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will call()
become the same as _only()
In this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One convention that I have been falling is called (), which is similar to _only or only, but it does not replace. call() has the Flutter core classes, and only has things like DTOs and etc.
|
||
BlendModeUtility<ImageSpecAttribute> get blendMode { | ||
return BlendModeUtility((blendMode) => _only(blendMode: blendMode)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One convention that I have been falling is called (), which is similar to _only or only, but it does not replace. call() has the Flutter core classes, and only has things like DTOs and etc.
d06771e
to
1dd0a17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue ticket number
resolve #166
Describe your changes
RectUtility
andFilterQualityUtility
;test_resources
to test Image widget.Type of change
Checklist before requesting a review