Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove function from Widget Tree #188

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Remove function from Widget Tree #188

merged 2 commits into from
Jan 31, 2024

Conversation

tilucasoli
Copy link
Collaborator

Issue ticket number

Describe your changes

  • Remove function from widget tree;
  • Rename StyleRecipe.selectVariants() to StyleRecipe.applyVariants()

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@tilucasoli tilucasoli requested a review from leoafarias January 31, 2024 18:01
@vercel Vercel
Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Jan 31, 2024 6:02pm

leoafarias
leoafarias approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias leoafarias merged commit d4524a1 into main Jan 31, 2024
4 checks passed
@leoafarias leoafarias deleted the fix/remove-function-from-tree branch January 31, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoafarias leoafarias leoafarias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tilucasoli @leoafarias