Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to decoration image #192

Merged
merged 5 commits into from
Feb 3, 2024
Merged

Support to decoration image #192

merged 5 commits into from
Feb 3, 2024

Conversation

tilucasoli
Copy link
Collaborator

@tilucasoli tilucasoli commented Feb 2, 2024 •
edited
Loading

Describe your changes

  • Implement support to DecorationImage

Type of change

  • New feature (non-breaking change which adds functionality)
  • Docs (changes to the documentation)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@vercel Vercel
Copy link

vercel bot commented Feb 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2024 7:31pm

@tilucasoli tilucasoli changed the title Feat/decoration image Support to decoration image Feb 2, 2024
@tilucasoli tilucasoli requested a review from leoafarias February 2, 2024 22:43
@leoafarias
Copy link
Member

@tilucasoli I made some minor adjustments and ran dcm linting. The main change is having an assert to throw an error if the DecorationImageDto does not have an image when resolving since it's required.

leoafarias
leoafarias approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias leoafarias merged commit 5edb8e1 into main Feb 3, 2024
6 checks passed
@leoafarias leoafarias deleted the feat/decoration-image branch February 3, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoafarias leoafarias leoafarias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tilucasoli @leoafarias