refactor: Add in code documentation and rename params for each component #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
github-actions
bot
added
documentation
tilucasoli
force-pushed
the
doc/remix-components
branch
from
27d0c2c to
2a00103
Compare
leoafarias
requested changes
Nov 15, 2024
|
|
||
| /// {@macro accordion_spec_of} | ||
| static const of = _$AccordionSpec.of; | ||
|
|
||
| static const from = _$AccordionSpec.from; | ||
|
|
||
| const AccordionSpec({ | ||
| BoxSpec? container, | ||
| FlexBoxSpec? flexContainer, |
There was a problem hiding this comment.
Lets change this to container
| final IconData? iconRight; | ||
|
|
||
| /// {@template remix.component.onPressed} |
There was a problem hiding this comment.
Let's move template definitions to the docs file
| titleStyle, | ||
| descriptionStyle, | ||
| actionsFlex, | ||
| actionsLayout, |
There was a problem hiding this comment.
Change this to actionsContainer and make it a FlexBox
| BoxSpec? outerContainer, | ||
| FlexSpec? contentLayout, | ||
| FlexSpec? titleSubtitleLayout, | ||
| FlexBoxSpec? flexContainer, |
| titleSubtitleLayout, | ||
| contentLayout, | ||
| titleSubtitleFlex, | ||
| flexContainer, |
| @@ -33,13 +33,13 @@ class SegmentedControlSpec extends Spec<SegmentedControlSpec> | |||
|
|
|||
| const SegmentedControlSpec({ | |||
| BoxSpec? container, | |||
| FlexSpec? flex, | |||
| FlexSpec? layout, | |||
There was a problem hiding this comment.
Combine this into the container and make it a FlexBoxSpec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Review Checklist