Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bring TextStyle properties to the root of TextSpecUtility #516

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

tilucasoli
Copy link
Collaborator

Description

  • Now TextStyle attributes are also available in direct in utility, with no need to call the style.

Before

`$text.style.color.red()`

After

`$text.color.red()`

Changes

  • Remove locale from the TextSpec because it is not style related;
  • Add alias to each parameter of TextStyle.

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 2:56pm

@github-actions github-actions bot added the mix label Nov 6, 2024
@tilucasoli tilucasoli merged commit 6df207f into main Nov 11, 2024
6 checks passed
@tilucasoli tilucasoli deleted the feat/bring-style-attributes-to-the-root-of-spec branch November 11, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants