Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Modernize MediaQuery usage #520

Merged

Conversation

cabaucom376
Copy link
Contributor

Related issue

N/A

Description

MediaQuery.of(context) updates when any property of MediaQuery does, specific calls like MediaQuery.sizeOf(context) only update when said properties update.

Changes

  • Updated MediaQuery usage

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

Additional Information (optional)

N/A

Copy link

vercel bot commented Nov 14, 2024

@cabaucom376 is attempting to deploy a commit to the FlutterTools Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the mix label Nov 14, 2024
@cabaucom376 cabaucom376 changed the title Modernize MediaQuery usage refactor: Modernize MediaQuery usage Nov 14, 2024
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias
Copy link
Member

Thanks @cabaucom376!

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 3:16pm

@tilucasoli tilucasoli merged commit 9c35bbc into conceptadev:main Nov 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants