Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Corrected some Actions #17

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Feat: Corrected some Actions #17

merged 1 commit into from
Sep 13, 2024

Conversation

GBowman1
Copy link
Collaborator

@GBowman1 GBowman1 commented Sep 13, 2024 •
edited
Loading

Type of Change

  • New Feature
  • Debugging
  • Refactor

Describe Changes Made

This pull request fixes some controller actions that were not working as intended. See files changed for the actions

PR Checklist

  • Added Reviewer
  • Followed TDD, And Test are Passing

clydeautin
clydeautin approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@clydeautin clydeautin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, cant believe this stuff passed tests earlier, I guess its a good reminder that you can't always fully rely on Rails test to signal well written code

@clydeautin clydeautin merged commit e4b5309 into main Sep 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clydeautin clydeautin clydeautin approved these changes

@RodrigoACG RodrigoACG Awaiting requested review from RodrigoACG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GBowman1 @clydeautin