Testing/attendes #29
Merged
Testing/attendes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GBowman1
reviewed
Sep 19, 2024
| @@ -21,7 +21,7 @@ def destroy | |||
| end | |||
|
|
|||
| def index | |||
| attendees = Attendee.where(event_id: params[:event_id]) | |||
| attendees = Attendee.all | |||
There was a problem hiding this comment.
this might create a conflict with how the attendees for an event is being accessed
|
|
|
we are trying to get an index of a specific event so we were using the event_id param to search for it |
ohh okay ill work on that now and try to fix that |
It is now fixed |
GBowman1
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Describe Changes Made
Testing for the attendees and now 100% passing in simple cov. Also refactored a little bit of the index action
PR Checklist