Artist #6
Merged
Artist #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also note, i removed the coverage that was being tracked by git in earlier PR's and updated git ignore |
clydeautin
reviewed
Sep 12, 2024
There was a problem hiding this comment.
didnt know factory bot could do music band names
clydeautin
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Describe Changes Made
In this PR I built functionality to hit artist index with a search param as a artist name. It will return a list of artist matching the search param.
From there our front end can add buttons or functionality so they can pass a artist back to us that the user wants to save, the create action will create a record of a users artist this is where we will store that users "favorite artist"
this goes for the delete action aswell.
I went ahead and built Service, Facade, Poro and Serializer for the artist request for MusicBrainz API
PLEASE Review its 5 am and i started at 2 am, i could have made plenty of mistakes
PR Checklist