-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add undocumented about section fields (meta.yaml documentation) #5215
Conversation
We require contributors to sign our Contributor License Agreement and we don't have one on file for @ytausch. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#890), and ping the bot to refresh the PR. |
@conda-bot check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look ok to to me as well.
(bsdiff4, bspatch4) and tests. | ||
dev_url: https://github.com/ilanschnell/bsdiff4 | ||
doc_url: https://bsdiff4.readthedocs.io | ||
doc_source_url: https://github.com/ilanschnell/bsdiff4/blob/main/README.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add license_url
too?
doc_source_url: https://github.com/ilanschnell/bsdiff4/blob/main/README.rst | |
doc_source_url: https://github.com/ilanschnell/bsdiff4/blob/main/README.rst | |
license_url: https://github.com/ilanschnell/bsdiff4/blob/master/LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. #5250
Description
The about section had some fields undocumented (most of them only in the example in the beginning of the documentation). These are added here.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?