Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require explicit answer in SH license prompt #722

Merged
merged 2 commits into from
Sep 30, 2023

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Sep 25, 2023

Description

Closes #721

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 25, 2023
@jaimergp jaimergp marked this pull request as ready for review September 25, 2023 16:54
@jaimergp jaimergp requested a review from a team as a code owner September 25, 2023 16:54
@jaimergp
Copy link
Contributor Author

Tried locally and this is what you get now:

The License has to be read correctly so that dollar signs don't lead to an unset
parameter error:
You have to pay US $8, if you can read this.


Do you accept the license terms? [yes|no]
>>> 
Please answer 'yes' or 'no':'
>>> 
Please answer 'yes' or 'no':'
>>> 
Please answer 'yes' or 'no':'
>>> 
Please answer 'yes' or 'no':'
>>> 
Please answer 'yes' or 'no':'
>>> 
Please answer 'yes' or 'no':'
>>> 
Please answer 'yes' or 'no':'
>>> 
Please answer 'yes' or 'no':'
>>> 
Please answer 'yes' or 'no':'
>>> n 
Please answer 'yes' or 'no':'
>>> no
The license agreement wasn't approved, aborting installation.

@jaimergp jaimergp merged commit 2302872 into conda:main Sep 30, 2023
13 checks passed
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Oct 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

License prompt in SH installers defaults to no on Enter
3 participants