Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation for windows .exe #736

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Update installation for windows .exe #736

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fc4142e
change MessageBox if path already exist
huche6 Dec 12, 2023
c2832a9
add SetOverwrite "off" if no selected
huche6 Dec 14, 2023
6bc801c
add a check validity of the target dir when updating
huche6 Dec 14, 2023
e8ebff6
Corrected the CheckInstdirValidity
huche6 Dec 14, 2023
c2f2278
removed the fact that the update has to be in the same repo
huche6 Dec 15, 2023
a9d535b
trailing whitespace correction
huche6 Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 75 additions & 5 deletions constructor/nsis/main.nsi.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,68 @@ Function InstModePage_Leave
Pop $0
FunctionEnd

Function CheckInstdirValidity
Push $0
Push $1
Push $2
Push $3

# Resolve INSTDIR
GetFullPathName $0 $INSTDIR
# If the directory does not exist or cannot be resolved, $0 will be empty
StrCmp $0 "" invalid_dir
StrCpy $INSTDIR $0

# Never run the un/installer when $INSTDIR points at system-critical directories

StrLen $InstDirLen $INSTDIR
# INSTDIR is a full path and has no trailing backslash,
# so if its length is 2, it is pointed at a system root
StrCmp $InstdirLen 2 invalid_dir

# Never delete anything inside Windows
StrCpy $0 $INSTDIR 7 3
StrCmp $0 "Windows" invalid_dir

StrCpy $0 "ALLUSERSPROFILE APPDATA LOCALAPPDATA PROGRAMDATA PROGRAMFILES PROGRAMFILES(x86) PUBLIC SYSTEMDRIVE SYSTEMROOT USERPROFILE"
StrCpy $1 1
loop_critical:
${WordFind} $0 " " "E+$1" $2
IfErrors endloop_critical
ReadEnvStr $3 $2
StrCmp $3 $INSTDIR invalid_dir
IntOp $1 $1 + 1
goto loop_critical
endloop_critical:

# Primitive check to see that $INSTDIR points to the right conda directory
StrCpy $0 "_conda.exe conda-meta\history"
StrCpy $1 1
loop_conda:
${WordFind} $0 " " "E+$1" $2
IfErrors endloop_conda
IfFileExists $INSTDIR\$2 0 invalid_dir
IntOp $1 $1 + 1
goto loop_conda
endloop_conda:

# All checks have passed
goto valid_dir

invalid_dir:
MessageBox MB_OK|MB_ICONSTOP \
"Error: $INSTDIR is not a valid conda directory or another conda directory.$\n\
Please run the installer from a conda directory." \
/SD IDABORT
abort
valid_dir:

Pop $3
Pop $2
Pop $1
Pop $0
FunctionEnd

Function .onInit
${LogSet} on
Push $0
Expand Down Expand Up @@ -844,12 +906,20 @@ Pop $0
Function OnDirectoryLeave
${LogSet} on
${If} ${IsNonEmptyDirectory} "$InstDir"
DetailPrint "::error:: Directory '$INSTDIR' is not empty, please choose a different location."
MessageBox MB_OK|MB_ICONEXCLAMATION \
DetailPrint "::error:: Directory '$INSTDIR' is not empty."

MessageBox MB_YESNO \
"Directory '$INSTDIR' is not empty,$\n\
please choose a different location." \
/SD IDOK
Abort
do you want to update the installation ?" \
/SD IDYES \
IDYES confirmed_yes IDNO confirmed_no
confirmed_no:
MessageBox MB_OK|MB_ICONSTOP "Choose another directory." /SD IDOK
SetOverwrite "off"
Abort
confirmed_yes:
call CheckInstdirValidity
SetOverwrite "ifdiff"
${EndIf}

ReadRegStr $LongPathsEnabled HKLM "SYSTEM\CurrentControlSet\Control\FileSystem" "LongPathsEnabled"
Expand Down