Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render post-install pages for Windows when input is a string #904

Merged
merged 7 commits into from
Nov 28, 2024

Conversation

marcoesters
Copy link
Contributor

Description

Windows assumed that post_install_pages is a list, but can also be a string. This PR fixes this.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 25, 2024
@marcoesters marcoesters marked this pull request as ready for review November 25, 2024 23:39
@marcoesters marcoesters requested a review from a team as a code owner November 25, 2024 23:39
tests/test_examples.py Outdated Show resolved Hide resolved
@marcoesters marcoesters requested a review from jaimergp November 26, 2024 15:42
@jaimergp jaimergp merged commit d85133d into conda:main Nov 28, 2024
18 checks passed
@marcoesters marcoesters deleted the extra-pages-list branch December 2, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants