Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin client impl fixes #1823

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

siobhan-sterrett
Copy link

A handful of minor fixes to cimpl. Probably nothing that will impact real-life use-cases, since these are all buried inside _AdminClientImpl, but they were bothering me.

  1. Swaps "topic_names" and "future" in kws array in Admin_describe_topics()

If a user tried to pass topic_names or future into _AdminClientImpl.describe_topics() as keyword arguments, they would end up swapped, which would lead to confusing errors.

  1. Raises TypeError in Admin_list_consumer_group_offset() if request is not a list
  2. Raises TypeError in Admin_alter_consumer_group_offsets() if request is not a list

In both of these cases, the library would raise ValueError if request was a list with anything other than 1 item... but if request wasn't a list, it would result in an internal error when it tried to access its first item.

  1. Allows elements of plist in py_to_c_parts() to be instances of a subtype of TopicPartition

If a user passed a list of instances of a subtype of TopicPartition, the library would raise a TypeError, even if the instances were otherwise valid.

@siobhan-sterrett siobhan-sterrett requested review from a team as code owners September 26, 2024 17:52
Copy link

cla-assistant bot commented Sep 26, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Siobhán Sterrett seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
Copy link

cla-assistant bot commented Sep 26, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Siobhán Sterrett seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@joaoe
Copy link

joaoe commented Sep 30, 2024

I think this might touch some code I changed here
#1591

But this project is not accepting PRs. It's annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants