feat: pendle #364
Merged
feat: pendle #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergarces
reviewed
Oct 28, 2024
| reserveConfigurationData.isFrozen | ||
| ) { | ||
| return | ||
| } |
There was a problem hiding this comment.
So... we want to show inactive and frozen pools?
I don't remember why we added this in the first place. Is there any example that wasn't showing before?
bergarces
reviewed
Oct 28, 2024
|
|
||
| return protocolToken | ||
| }, | ||
| ) |
There was a problem hiding this comment.
At least add a TODO here, because when we can update the metadata db dynamically we 1000000% don't want to do this, as it's just delaying fetching positions whilst waiting for block info.
There was a problem hiding this comment.
Hey,
I see - you are saying we run metadata daily then save isExpired to true in db, interesting
You found a good use case to run the metadata daily.
bergarces
previously approved these changes
Oct 28, 2024
bergarces
force-pushed
the
pendle-expiry-fix
branch
from
9a84029 to
ae882c6
Compare
bergarces
force-pushed
the
pendle-expiry-fix
branch
from
2976aa3 to
ba6efd8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.