Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mmi 5819 convex missing positions #382

Merged
merged 9 commits into from
Dec 6, 2024
Merged

Mmi 5819 convex missing positions #382

merged 9 commits into from
Dec 6, 2024

Conversation

bergarces
Copy link
Collaborator

@bergarces bergarces commented Nov 26, 2024 •
edited
Loading

  • Fix cvxcrv-wrapper to return cvxcrv underlying token as well as rewards. Now also not using SimplePoolAdapter.
  • Tidy up cvxcrv-wrapper test cases.
  • Added adapters for staked cvx and locked cvx.

@bergarces bergarces requested a review from jpsains as a code owner November 26, 2024 15:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 30%)
33.1% Duplication on New Code (required ≤ 7%)

See analysis details on SonarQube Cloud

@bergarces bergarces merged commit e42832a into main Dec 6, 2024
50 of 51 checks passed
@bergarces bergarces deleted the MMI-5819-convex-missing-positions branch December 6, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpsains jpsains Awaiting requested review from jpsains jpsains is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bergarces