Support live testing for developers #221
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library has unit tests:
The problem
We don't test if an API request built by the library will actually behave as expected on the Jira side. Testing stuff like that is of course out of the scope, because if we've made an API call according to the Jira REST API docs, then we believe it will work as expected.
The solution
Before sending a PR a developer must confirm, that the added code will actually produce the correct results. Here is why the
ApiTest::testLive
test was added.It works like this:
phpunit.xml.dist
intophpunit.xml
phpunit.xml
specifyLIVE_TEST_ENDPOINT
,LIVE_TEST_USERNAME
andLIVE_TEST_PASSWORD
environment variables (example code is already placed in there; just uncomment it)ApiTest::testLive
method.