Proposal PR: Userspace Convertor: Add Deduplication Version Support #271
+291
−89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a simple versioning system for the userspace convertor deduplication dbs. This prevents inconsistencies with an existing DB if a new version is used.
What this PR does / why we need it:
This is a proposal PR on how to handle versioning for the layer/manifest deduplication going forward. It is not done as is since we still need some way of finding the version of the overlaybd tools to combine with the local deduplication versions. I furthermore propose that major versions for the tools denote a break in the digest outputs. I also updated the sample workload file to include more info and validation as well as added some unit tests. We can probably incorparete that with the tests but tbh I am unclear on how at the moment.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #250
Please check the following list: