Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal PR: Userspace Convertor: Add Deduplication Version Support #271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

estebanreyl
Copy link
Member

Introduce a simple versioning system for the userspace convertor deduplication dbs. This prevents inconsistencies with an existing DB if a new version is used.

What this PR does / why we need it:
This is a proposal PR on how to handle versioning for the layer/manifest deduplication going forward. It is not done as is since we still need some way of finding the version of the overlaybd tools to combine with the local deduplication versions. I furthermore propose that major versions for the tools denote a break in the digest outputs. I also updated the sample workload file to include more info and validation as well as added some unit tests. We can probably incorparete that with the tests but tbh I am unclear on how at the moment.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #250

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Introduce a simple versioning system for the userspace convertor. This
prevents inconsistencies with an existing DB if a new version is used

Signed-off-by: Esteban <[email protected]>
@estebanreyl estebanreyl marked this pull request as ready for review March 21, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Userspace Convertor] Overlaybd Layer Versioning for Deduplication
1 participant