Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default out_dir support #262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jokemanfire
Copy link
Contributor

If not set out_dir,it will use env 'OUT_DIR' to generate proto rs file.You can use 'include!' marco to include env 'OUT_DIR' proto rs .
And you needn't to create a dir in your source dir.

@Tim-Zhang
Copy link
Member

@jokemanfire The feature is useful, and I think we'd better not update the example because I occasionally need to check the generated code and out_dir is not easy to find. By the way, please take a look at the failed CI, thanks

@jokemanfire jokemanfire force-pushed the dev6 branch 2 times, most recently from 62d9168 to dbda636 Compare November 4, 2024 11:56
If not set out_dir,it will use env 'OUT_DIR',to generate proto rs file.
You can use 'include!' marco to include env 'OUT_DIR' proto rs .

Signed-off-by: jokemanfire <[email protected]>
@jokemanfire
Copy link
Contributor Author

@jokemanfire The feature is useful, and I think we'd better not update the example because I occasionally need to check the generated code and out_dir is not easy to find. By the way, please take a look at the failed CI, thanks

Ok ,I've changed and add usage in doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants