Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(whispercpp): adding missing ownership to user 1001 in app directory #747

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Aug 8, 2024

Fixes #743

The user 1001 needs permission to write to the /app directory as it creates a temp file in the current directory.

See https://github.com/ggerganov/whisper.cpp/blob/fe36c909715e6751277ddb020e7892c7670b61d4/examples/server/server.cpp#L680 for ref

@axel7083
Copy link
Contributor Author

axel7083 commented Aug 8, 2024

cc @johnmcollier

@rhatdan
Copy link
Member

rhatdan commented Aug 8, 2024

Just setting the directory to 1001 does not modify the ownership of any content in the directly, which would be owned by root?

Do you want the entire directory to be owed by UID=1001?

Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, /lgtm

@Gregory-Pereira Gregory-Pereira merged commit 2249889 into containers:main Aug 8, 2024
7 checks passed
@axel7083
Copy link
Contributor Author

axel7083 commented Aug 9, 2024

Just setting the directory to 1001 does not modify the ownership of any content in the directly, which would be owned by root?

Yes that's not an issue, as user 1001 does not need to change anything existing, it just need to be able to write some file in it.

Do you want the entire directory to be owed by UID=1001?

I want the USER 1001 to be able to write a file in the directory, precisely the whisper_server_temp_file.wav they uses for tmp file conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

whisper image is broken on main
3 participants