chore: tag model_servers images on release #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel7083
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
|
LGTM |
rhatdan
approved these changes
Aug 12, 2024
|
Can you merge your commits. git rebase -i origin |
axel7083
force-pushed
the
chore/tag-on-release
branch
from
556ae70 to
d2fdbd2
Compare
|
You still have two commits I want you to squash them together. |
Signed-off-by: axel7083 <[email protected]> fix: missing $ Signed-off-by: axel7083 <[email protected]>
axel7083
force-pushed
the
chore/tag-on-release
branch
from
d2fdbd2 to
2130f92
Compare
rhatdan
reviewed
Aug 12, 2024
| @@ -97,7 +99,7 @@ jobs: | |||
| with: | |||
| image: ${{ env.REGISTRY }}/${{ github.repository_owner}}/${{ matrix.image_name }} | |||
| platforms: ${{ matrix.platforms }} | |||
| tags: latest | |||
| tags: latest ${{ github.ref_type == 'tag' && github.ref_name || '' }} | |||
There was a problem hiding this comment.
Does this end up with
tags: latest githup.ref_name? if set?
Or should it be just
tags: githup.ref_name
There was a problem hiding this comment.
tags: latest githup.ref_name? if set? yes
|
You also lost your commit message? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tag the container images of the model_servers with the
ref_nameif one is provided.Fixes #748
According to the redhat-actions/buildah-build documentation, the tags should be separated with white spaces1
Footnotes
https://github.com/marketplace/actions/buildah-build#image-and-tags-inputs ↩