Skip to content

Commit

Permalink
tree: Add missing -v /dev:/dev in a few places
Browse files Browse the repository at this point in the history
We're really going to need to switch over to having the container
do dynamic mounts; cc #380 (comment)

Just noticed this missing in one place, and found others with
a grep.

Right now we do operate without, but it can be racier.

Signed-off-by: Colin Walters <[email protected]>
  • Loading branch information
cgwalters committed Jun 22, 2024
1 parent 163c1e5 commit 5271519
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion hack/lldb/deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ sudo podman build --build-arg "sshpubkey=$(cat ~/.ssh/id_rsa.pub)" -f Containerf
mkdir -p ~/.cache/bootc-dev/disks
rm -f ~/.cache/bootc-dev/disks/lldb.raw
truncate -s 10G ~/.cache/bootc-dev/disks/lldb.raw
sudo podman run --pid=host --network=host --privileged --security-opt label=type:unconfined_t -v /var/lib/containers:/var/lib/containers -v ~/.cache/bootc-dev/disks:/output -v /dev:/dev localhost/bootc-lldb bootc install to-disk --via-loopback --generic-image --skip-fetch-check /output/lldb.raw
sudo podman run --pid=host --network=host --privileged --security-opt label=type:unconfined_t -v /dev:/dev -v /var/lib/containers:/var/lib/containers -v ~/.cache/bootc-dev/disks:/output -v /dev:/dev localhost/bootc-lldb bootc install to-disk --via-loopback --generic-image --skip-fetch-check /output/lldb.raw

# create a new VM in libvirt
set +e
Expand Down
1 change: 1 addition & 0 deletions tests/integration/image-install-upgrade.sh
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ case "$IMAGE_TYPE" in
--privileged \
--pid=host \
--security-opt label=type:unconfined_t \
-v /dev:/dev \
-v /var/lib/containers:/var/lib/containers \
-v /dev:/dev \
-v .:/output \
Expand Down
1 change: 1 addition & 0 deletions tests/integration/playbooks/install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
--rm \
--privileged \
--pid=host \
-v /dev:/dev \
-v /:/target \
-v /var/lib/containers:/var/lib/containers \
--security-opt label=type:unconfined_t \
Expand Down

0 comments on commit 5271519

Please sign in to comment.