install: Two smaller fixes #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to need to consistently use a helper to get this right in the future...basically most uses of `.output()` are wrong. Signed-off-by: Colin Walters <[email protected]>
Our `exec-in-host-mount-namespace` internal helper was intended to be a "passthrough" that accepts whatever child arguments. However I misunderstood how to do this in clap. Before this change we get: ``` $ bootc blabla ERROR Re-exec in host mountns: Missing command ``` i.e. the exec code kicks in because `external_subcommand` takes over *everything* unknown. Fix things to use `trailing_var_arg` which is intended for this case. After this patch: ``` $ bootc blabla error: unrecognized subcommand 'blabla' Usage: bootc <COMMAND> For more information, try '--help'. ``` Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
reexec-fix
branch
from
6760287 to
d82446a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install: Propagate skopeo stderr
We're going to need to consistently use a helper to get this right
in the future...basically most uses of
.output()are wrong.Signed-off-by: Colin Walters [email protected]
install: Fix exec helper to not swallow unexpected args
Our
exec-in-host-mount-namespaceinternal helper was intendedto be a "passthrough" that accepts whatever child arguments.
However I misunderstood how to do this in clap. Before this
change we get:
i.e. the exec code kicks in because
external_subcommandtakesover everything unknown.
Fix things to use
trailing_var_argwhich is intended for this case.After this patch:
Signed-off-by: Colin Walters [email protected]