install: Support gathering more info for host root (including LVM) #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
I had this as draft as it was building on the other PR, but maybe it's simpler to just merge them together now. |
Teach `install to-existing-root` how to gather kernel arguments and information we need from `/proc/cmdline` (such as `rd.lvm.lv`). In this case too, we need to adjust the args to use `-v /dev:/dev` because we need the stuff udev generates from the real host root. With these things together, I can do a bootc alongside install targeting a Fedora Server instance. Closes: containers#175 Signed-off-by: Colin Walters <[email protected]>
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #382
install: Support gathering more info for host root (including LVM)
Teach
install to-existing-roothow to gather kernel argumentsand information we need from
/proc/cmdline(such asrd.lvm.lv).In this case too, we need to adjust the args to use
-v /dev:/devbecause we need the stuff udev generates from the real host root.
With these things together, I can do a bootc alongside install
targeting a Fedora Server instance.
Closes: #175
Signed-off-by: Colin Walters [email protected]