Bound install time #712
Merged
Bound install time #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, this works for me to pull bound images at install time by default (and is a somewhat improved version of what was in my original PR). However:
|
ckyrouac
approved these changes
Jul 19, 2024
I think it's generally best to have type definitions come before the code that references them. Signed-off-by: Colin Walters <[email protected]>
We were always passing this single constant value to the function; let's just reference it inside the function and simplify callers. Signed-off-by: Colin Walters <[email protected]>
I think this name is a bit clearer. Signed-off-by: Colin Walters <[email protected]>
Prep for using them in the install path. Signed-off-by: Colin Walters <[email protected]>
Unless overridden by a CLI option, in which case they will likely be pulled on firstboot. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
bound-install-time
branch
from
aa4cd41 to
d4acdce
Compare
|
OK, rebased 🏄 on git main and lifting draft. I also added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils: Drop unnecessary lint allow
This function doesn't use unsafe anymore.
Signed-off-by: Colin Walters [email protected]
boundimage: Use high level
deployment_fdhelperThis keeps things even simpler, it's the same thing we're doing
in
kargs.rs.Signed-off-by: Colin Walters [email protected]
boundimage: More struct definition to top
I think it's generally best to have type definitions come before
the code that references them.
Signed-off-by: Colin Walters [email protected]
boundimage: Drop const parameter
We were always passing this single constant value to the
function; let's just reference it inside the function
and simplify callers.
Signed-off-by: Colin Walters [email protected]
boundimage: Rename helper function
I think this name is a bit clearer.
Signed-off-by: Colin Walters [email protected]
boundimage: Make helpers
pub(crate)Prep for using them in the install path.
Signed-off-by: Colin Walters [email protected]
install: Pull bound images by default
Unless overridden by a CLI option, in which case they will
likely be pulled on firstboot.
Signed-off-by: Colin Walters [email protected]