Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Add hidden ensure-completion verb #915

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cgwalters
Copy link
Collaborator

@cgwalters cgwalters commented Nov 20, 2024

This will be runnable via

%post --erroronfail
bootc install ensure-completion
%end

in Anaconda to work around the fact that it's not today using bootc install to-filesystem.

Closes: #883

@cgwalters
Copy link
Collaborator Author

cgwalters commented Nov 20, 2024

This seems to be working well in my hand-rolled testing.
(BTW I am testing via virt-manager/virt-manager#739 (comment) )

Still TODO:

@cgwalters
Copy link
Collaborator Author

OK I've rebased this on top of #860 and we successfully pull LBIs at Anaconda install time too now.

@cgwalters
Copy link
Collaborator Author

There were a surprising number of things I hit. One of them for example is that anaconda's hand-rolled chroot/container doesn't mount cgroupfs which makes podman quite unhappy so we do so manually in https://github.com/containers/bootc/pull/915/files#diff-66bc72c28514e2546fbe456aee74a321866d5a9147136ef99251eec1e08be8ddR107

Prep for the anaconda install completion work.

Signed-off-by: Colin Walters <[email protected]>
No functional changes; prep for further work.

Signed-off-by: Colin Walters <[email protected]>
Clean up the interception to prepare for other cases.

Signed-off-by: Colin Walters <[email protected]>
This allows us to fully own the symlinks in `/usr/libexec/libostree/ext`.

Signed-off-by: Colin Walters <[email protected]>
This will be runnable via
```
%post --erroronfail
bootc install ensure-completion
%end
```

in Anaconda to work around the fact that it's not today
using `bootc install to-filesystem`.

Signed-off-by: Colin Walters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install` do-not-merge/work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install: Add bootc install finish to take over from "raw ostree" installs
1 participant