Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Add interception for ostree extension verbs #916

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

cgwalters
Copy link
Collaborator

cli: Factor out helper to parse "callname"

No functional changes; prep for further work.

Signed-off-by: Colin Walters [email protected]


cli: Prepare for other argv0 dispatching

Clean up the interception to prepare for other cases.

Signed-off-by: Colin Walters [email protected]


cli: Add interception for ostree extension verbs

This allows us to fully own the symlinks in /usr/libexec/libostree/ext.

Signed-off-by: Colin Walters [email protected]


Copy link

@allisonkarlitskaya allisonkarlitskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly style fly-bys from me on this one. I'm afraid I don't understand the larger picture. Let's talk in standup?

lib/src/cli.rs Outdated Show resolved Hide resolved
lib/src/cli.rs Show resolved Hide resolved
lib/src/cli.rs Show resolved Hide resolved
lib/src/cli.rs Show resolved Hide resolved
No functional changes; prep for further work.

Signed-off-by: Colin Walters <[email protected]>
Clean up the interception to prepare for other cases.

Signed-off-by: Colin Walters <[email protected]>
This allows us to fully own the symlinks in `/usr/libexec/libostree/ext`.

Signed-off-by: Colin Walters <[email protected]>
This an optional bit for those that need `ostree container`.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters force-pushed the dispatch-ostree-container-argv0 branch from 7c46987 to 2e8142b Compare November 26, 2024 15:55
@cgwalters
Copy link
Collaborator Author

@allisonkarlitskaya mind stamping this?

Copy link

@allisonkarlitskaya allisonkarlitskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cgwalters cgwalters merged commit fb8c1e9 into containers:main Nov 27, 2024
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants