Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: fix Unknown argument "builddep" for command "dnf5" #969

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

henrywang
Copy link
Contributor

@henrywang henrywang commented Dec 13, 2024

The copr build environment looks upgrade to Fedora 41 now, dnf5 has been used since that. That caused dnf builddep command error.

dnf -y builddep ./contrib/packaging/bootc.spec
Unknown argument "builddep" for command "dnf5". Add "--help" for more information about the arguments.
It could be a command provided by a plugin, try: dnf5 install 'dnf5-command(builddep)'
make: *** [/mnt/workdir-c4js6f0t/bootc/.copr/Makefile:5: srpm] Error 2

dnf5 needs dnf5-command(builddep) installed to run "dnf builddep"

The copr build failure log: https://log-detective.com/contribute/copr/8384952/srpm-builds#

The copr build environment looks upgrade to fedora 41 now, dnf5
has been used. That caused dnf builddep command error.

dnf5 needs dnf5-command(builddep) installed to run "dnf builddep"

Signed-off-by: Xiaofeng Wang <[email protected]>
@henrywang henrywang requested a review from cgwalters December 13, 2024 01:43
@@ -1,4 +1,5 @@
srpm:
dnf5 -y install 'dnf5-command(builddep)'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to explicitly type dnf5 here, but it doesn't hurt either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. It's wired indeed. I'll send another PR to fix this.

@cgwalters cgwalters merged commit 35e7ff1 into containers:main Dec 13, 2024
25 checks passed
@henrywang henrywang deleted the fix_copr_build branch December 13, 2024 02:54
@henrywang
Copy link
Contributor Author

Yes! The copr build succeeded again! https://copr.fedorainfracloud.org/coprs/rhcontainerbot/bootc/build/8386710/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants