-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/buildahimage: set config correctly for rootless build
user
#4905
contrib/buildahimage: set config correctly for rootless build
user
#4905
Conversation
For image published at `quay.io/containers/buildah` buildah should correctly use `fuseoverlay` for rootless `build` user `fuse-overlayfs`. Closes: containers#4669 [NO NEW TESTS NEEDED] Signed-off-by: Aditya R <[email protected]>
Does this fix this issue? |
LGTM |
@containers/buildah-maintainers PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
/hold |
@flouthoc PTAL, tests are not at all happy |
@TomSweeneyRedHat It was caused due to temporary outage of |
/hold cancel |
For image published at
quay.io/containers/buildah
buildah should correctly usefuseoverlay
for rootlessbuild
userfuse-overlayfs
.Closes: #4669
[NO NEW TESTS NEEDED]
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?