copier: handle globbing with "**" path components #5688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/feature
nalind
force-pushed
the
copyglob
branch
10 times, most recently
from
5634cf4 to
b46edf0
Compare
nalind
force-pushed
the
copyglob
branch
3 times, most recently
from
4b4af3f to
a2db852
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rhatdan
reviewed
Sep 3, 2024
| // will be concatenated. | ||
| func extendedGlob(pattern string) (matches []string, err error) { | ||
| subdirectories := func(dir string) []string { | ||
| var subdirectories []string |
There was a problem hiding this comment.
This is difficult to read, since the function and the variable have the same name. Would have been better if they were different.
rhatdan
reviewed
Sep 3, 2024
copier/copier.go
Outdated
| if len(expanded) > 1 { | ||
| patterns = append(append(patterns[:i], expanded...), patterns[i+1:]...) | ||
| } else { | ||
| i++ |
There was a problem hiding this comment.
We don't know that patterns[i+1] (if we're not at the end of the slice) doesn't need to be expanded.
Handle glob patterns with "**" path components by expanding "**" to the set of subdirectories and calling filepath.Glob() on the results. Signed-off-by: Nalin Dahyabhai <[email protected]>
|
/lgtm |
openshift-merge-bot
bot
merged commit fb40f69
into
containers:main
38 of 39 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Handle glob patterns with "**" path components by expanding "**" to the set of subdirectories and calling filepath.Glob() on the results.
How to verify it
New unit test!
New conformance tests!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?