Vendor c/common:9d025e4cb348
#5710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Oops, I’m afraid I didn’t think to look at the Buildah CLI for users (I was assuming that the Buildah code vendored into Podman would cover all of the Buildah codebase).
- It’s … not entirely clear to me that
buildah images --filter … singleImageNameis expected. But the old code did implement that, so making an effort might make sense. - Reading how
argsis treated, it always has either 0 or 1 elements. So, I think we don’t really need animagesByNamesset; if we have a single name to look up, deal with that one name.
Honny1
force-pushed
the
vendro-c-common
branch
from
11ae3e2 to
d480f2d
Compare
|
@Honny1 can you rebase this, looks like there is merge conflict now |
|
Looks like I do not have approve power here either. |
Signed-off-by: Jan Rodák <[email protected]>
Honny1
force-pushed
the
vendro-c-common
branch
from
d480f2d to
ed881ab
Compare
|
@Luap99 I made a rebase. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, Luap99, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR vendor pre-release version of
c/common:9d025e4cb348fixes containers/podman#23331. It also adapts the code to the newc/common/libimageAPI.What type of PR is this?
In pre-release version of c/common is fixed flake containers/podman#23331. This fix changes API of c/common. So it needs adapt the code to the new
c/common/libimageAPI. And avoid unexpected issue for next vendor dance./kind flake
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Fixes containers/podman#23331
Special notes for your reviewer:
Does this PR introduce a user-facing change?