[release-1.27] Properly validate cache IDs and sources #5797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--mount type=cache` argument to the `RUN` instruction in Dockerfiles was using `filepath.Join` on user input, allowing crafted paths to be used to gain access to paths on the host, when the command should normally be limited only to Buildah;s own cache and context directories. Switch to `filepath.SecureJoin` to resolve the issue. Fixes CVE-2024-9675 N/B: The system test was slightly modified from the original fix done by Matt. The older CI environments used by this release successfully block the escape with SELinux. Signed-off-by: Matt Heon <[email protected]> Signed-off-by: David Shea <[email protected]> Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: David Shea <[email protected]>
|
Sorry for spreading these out this is the last one. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashea, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override "Total Success" |
|
@nalind: Overrode contexts on behalf of nalind: Total Success In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit a64c647
into
containers:release-1.27
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Backport fix for CVE-2024-9675 to release-1.27 branch
How to verify it
Test included in PR
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/RHEL-62385
https://issues.redhat.com/browse/RHEL-62376
Special notes for your reviewer:
Does this PR introduce a user-facing change?