-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.34] integration tests: switch some base images #5815
[release-1.34] integration tests: switch some base images #5815
Conversation
Replace some of the base images we've been using (particularly centos:8, which will EOL soon) with other images hosted on quay.io. We already use registries.conf at test-time to redirect some image references there, so this will slightly reduce the number of registries which we need to be able to reach while running these tests. Signed-off-by: Nalin Dahyabhai <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ephemeral COPR build failed. @containers/packit-build please check. |
/label jira |
@nalind: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
CentOS and RHEL are moving to 1.37, so we don't need to try to build for them (and EOL Fedora releases) when we know those attempts will fail. Signed-off-by: Nalin Dahyabhai <[email protected]>
278bfce
to
4fae9a2
Compare
Changes LGTM |
Assuming it's up to date, the bottom of https://fedorapeople.org/groups/schedule/f-39/f-39-all-tasks.html notes that Fedora 39's end-of-life date will be less than a week from now. |
Yes, ok to ignore. Remind me what centos/rhel this branch will be used for. I don't think any fedora will use this, so we can just use the centos targets for packit. |
/lgtm |
And I should have asked, can we remove the f39 tests from this and the other branches? |
51a007c
into
containers:release-1.34
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Replace some of the base images we've been using (particularly centos:8, which will EOL soon) with other images hosted on quay.io.
We already use registries.conf at test-time to redirect some image references there, so this will slightly reduce the number of registries which we need to be able to reach while running these tests.
Manually cherry-picked from #5499 to resolve conflicts.
How to verify it
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?