Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(not just) Makefile cleanups #5832

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Nov 9, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Cleaning up parts of Makefile (and other relevant bits) that are no longer needed / obsolete.

Please see individual commits for details.

none

@kolyshkin kolyshkin changed the title Makefile cleanups (not just) Makefile cleanups Nov 9, 2024
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Nov 11, 2024

LGTM

This is no longer used since commit 3a122aa.

[NO NEW TESTS NEEDED]

Signed-off-by: Kir Kolyshkin <[email protected]>
Since commit c7937cd it is no longer necessary to have it.

[NO NEW TESTS NEEDED]

Signed-off-by: Kir Kolyshkin <[email protected]>
It looks like those were added to aim in CI, and is no longer required.
As it is quite unexpected to have make targets operate on directories such
as ../../, let's remove those.

Fix Ubuntu build instructions accordingly (runc binary package is
available in those distros).

[NO NEW TESTS NEEDED]

Signed-off-by: Kir Kolyshkin <[email protected]>
For quite some time (Go 1.16? To be honest, I don't remember) placing
sources in a specific directory under $GOPATH is no longer required.

[NO NEW TESTS NEEDED]

Signed-off-by: Kir Kolyshkin <[email protected]>
[NO NEW TESTS NEEDED]

Signed-off-by: Kir Kolyshkin <[email protected]>
It is cleaner that way.

While at it, let's try to minimize it.

[NO NEW TESTS NEEDED]

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin marked this pull request as ready for review November 11, 2024 18:49
@nalind
Copy link
Member

nalind commented Nov 12, 2024

Thanks!
/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, Luap99, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a65fd39 into containers:main Nov 12, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants