executor: allow to specify --no-pivot-root #5838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
added
the
No New Tests
the functionality is already implemented, it must be exposed through the BuildOptions struct. Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
executor-pass-no-pivot-root
branch
from
ce09834 to
eb7a422
Compare
|
Shouldn't this be wired into |
|
We no not expose this on the podman cli either, we just have a containers.conf option and so far nobody has asked for one AFAIK |
|
Ok, then let's merge it in. /approve I would rather not expose it from CLI if possible. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the functionality is already implemented, it must be exposed through the BuildOptions struct.
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
needed for: containers/podman#24546