chroot: on Linux, try to pivot_root before falling back to chroot #5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/design
nalind
force-pushed
the
chroot-pivot-root
branch
from
e5abfae to
781fdb8
Compare
Unless --no-pivot or the equivalent API flag is set, try to pivot_root() to enter the rootfs during Run(). Fall back to using chroot() as before if that fails for any reason. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
chroot-pivot-root
branch
from
781fdb8 to
4adca28
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nalind
commented
Dec 13, 2024
| if err := RunUsingChroot(g.Config, bundleDir, "/", new(bytes.Buffer), output, output); err != nil { | ||
| t.Fatalf("run: %v: %s", err, output.String()) | ||
| if err := RunUsingChroot(g.Config, bundleDir, "/", new(bytes.Buffer), output, output, noPivot); err != nil { | ||
| t.Fatalf("run(noPivot=false): %v: %s", err, output.String()) |
There was a problem hiding this comment.
Ugh, just spotted the literal "=false" instead of using the passed-in value, opened #5876 to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless --no-pivot or the equivalent API flag is set, try to pivot_root() to enter the rootfs during Run(). Fall back to using chroot() as before if that fails for any reason.
What type of PR is this?
/kind design
What this PR does / why we need it:
When using chroot isolation, if we can pivot_root() instead of using chroot() for running the command, do that, because it's closer to what a proper runtime can do.
How to verify it
Extended unit tests!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
We still need chroot() for things like unpacking layers while pulling images, so if you're hoping this means we no longer ever need CAP_SYS_CHROOT, sorry.
Does this PR introduce a user-facing change?