Skip to content

Commit

Permalink
Revert "Don't fall back if imagesIDsForManifest fails"
Browse files Browse the repository at this point in the history
This reverts commit 3339ddc.

Signed-off-by: Paul Holzinger <[email protected]>
  • Loading branch information
Luap99 committed Nov 4, 2024
1 parent 02df424 commit 4de7567
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions libimage/pull.go
Original file line number Diff line number Diff line change
Expand Up @@ -699,11 +699,10 @@ func (r *Runtime) copySingleImageFromRegistry(ctx context.Context, imageName str
}

logrus.Debugf("Pulled candidate %s successfully", candidateString)
ids, err := r.imagesIDsForManifest(manifestBytes, sys)
if err != nil {
return nil, err
if ids, err := r.imagesIDsForManifest(manifestBytes, sys); err == nil {
return ids, nil
}
return ids, nil
return []string{candidate.Value.String()}, nil
}

if localImage != nil && pullPolicy == config.PullPolicyNewer {
Expand Down

0 comments on commit 4de7567

Please sign in to comment.