change default machine image for windows #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsl no longer uses this field and for windows using hyperv, it should be set to "testing" like all other providers that use fcos as a base machine image. Signed-off-by: Brent Baude <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
LGTM |
|
/lgtm |
Luap99
reviewed
Aug 9, 2023
Comment on lines
7
to
9
| func getDefaultMachineImage() string { | ||
| return "35" | ||
| return "testing" | ||
| } |
There was a problem hiding this comment.
if all providers should return the same thing then this function should be removed from the _<os>.go files and the default should just be dinfed once for eveything
Also the comment of this function is now wrong.
baude
added a commit
to baude/common
that referenced
this pull request
Aug 11, 2023
small refactoring for containers#1603 adn containers#1608 where we no longer have operating system differences. Signed-off-by: Brent Baude <[email protected]>
baude
added a commit
to baude/common
that referenced
this pull request
Aug 11, 2023
small refactoring for containers#1603 adn containers#1608 where we no longer have operating system differences. Signed-off-by: Brent Baude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wsl no longer uses this field and for windows using hyperv, it should be set to "testing" like all other providers that use fcos as a base machine image.