Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MatchNegatedLabelFilter function for networks #1677

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Use MatchNegatedLabelFilter function for networks #1677

merged 1 commit into from
Sep 29, 2023

Conversation

jakecorrenti
Copy link
Member

Changes createPruneFilterFuncs to use filters.MatchNegatedLabelFilters instead of !filters.MatchLabelFilters when matching on negated labels (label!).

@jakecorrenti
Use MatchNegatedLabelFilter function for networks
f399a16 
Changes `createPruneFilterFuncs` to use
`filters.MatchNegatedLabelFilters` instead of
`!filters.MatchLabelFilters` when matching on negated labels (label!).

Signed-off-by: Jake Correnti <[email protected]>
@jakecorrenti jakecorrenti mentioned this pull request Sep 28, 2023
Closed
@rhatdan
Copy link
Member

rhatdan commented Sep 29, 2023

LGTM
/approve

flouthoc
flouthoc approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, jakecorrenti, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 16d441d into containers:main Sep 29, 2023
6 checks passed
@vrothberg
Copy link
Member

It looks like this PR got merged while the one in Podman (containers/podman#20197) is still red. Please avoid that as it may block others from working on c/common and getting things into Podman.

@flouthoc
Copy link
Collaborator

flouthoc commented Oct 3, 2023

Ouch @vrothberg should we revert this one then ? I wonder if c/common is now breaking.

@flouthoc
Copy link
Collaborator

flouthoc commented Oct 3, 2023 •
edited
Loading

It seems containers/podman#20197 is waiting for this PR, anyways we will fine broken c/common here: containers/podman#20242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flouthoc flouthoc flouthoc approved these changes

Assignees

@flouthoc flouthoc

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakecorrenti @rhatdan @vrothberg @flouthoc @openshift-merge-robot