Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ci image to f41 #2246

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Nov 12, 2024

No description provided.

Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Member Author

Luap99 commented Nov 13, 2024

Writing manifest to image destination
    push_test.go:60: 
        	Error Trace:	/var/tmp/go/src/github.com/containers/common/libimage/push_test.go:60
        	Error:      	"[0xc0003b2c80]" should have 2 item(s), but has 1
        	Test:       	TestPush
        	Messages:   	there should only be two images (alpine in Docke/OCI)
--- FAIL: TestPush (1.88s)

seems to be consistent

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99
Copy link
Member Author

Luap99 commented Nov 19, 2024

CI issue was fixed in #2250 so this should pass now

@edsantiago @mheon @rhatdan PTAL

@edsantiago
Copy link
Member

Oh, I missed #2250. Nice job of futureproofing.

LGTM

@edsantiago
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 80db614 into containers:main Nov 19, 2024
16 checks passed
@Luap99 Luap99 deleted the ci-update branch November 19, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants