fixes in error handling #413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriksjolund
force-pushed
the
fixes
branch
3 times, most recently
from
00714d9
to
3d59f93
Compare
|
Hopefully the PR makes sense. fuse-overlayfs is a complex piece of software. I realised that only after starting writing the PR. It's tricky to know if an error should be returned or not in some places. |
|
I started a discussion thread in the libfuse project about the github workflow test failure |
Signed-off-by: Erik Sjölund <[email protected]>
|
The libfuse bug that caused a test failure has now been fixed |
|
@eriksjolund @giuseppe What do we want to do with this one? |
I don't mind if you just close the PR. (I just want to give you this option because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I marked this PR as a draft because I haven't had the time to look into the details.
I hope to remove the draft status within 2 weeks.