Generate json_t from parsing the json string #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sourav Moitra <[email protected]>
Signed-off-by: Sourav Moitra <[email protected]>
saschagrunert
approved these changes
Nov 21, 2024
|
@giuseppe PTAL, code LGTM |
|
@saschagrunert please merge to switch-to-jansson as soon as you are happy with it :-) I think it is more important to move fast with the prototyping, we can deal with minor details later |
|
@saschagrunert added you as a maintainer of the project |
|
@giuseppe thank you! |
|
@saschagrunert @giuseppe Parsing of json has been converted to jansson only genration part still uses yajl by next week we should be using only jansson. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating the initial json_t instead of yajl_val and remove temporary function
Part of #138