-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to jansson sm Remove YAJL and Jansson #146
Switch to jansson sm Remove YAJL and Jansson #146
Conversation
Signed-off-by: Sourav Moitra <[email protected]>
Signed-off-by: Sourav Moitra <[email protected]>
Signed-off-by: Sourav Moitra <[email protected]>
Signed-off-by: Sourav Moitra <[email protected]>
@saschagrunert PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 nits, otherwise LGTM
Signed-off-by: Sourav Moitra <[email protected]>
@saschagrunert PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dev package should also provide the lib, right?
.github/workflows/test.yaml
Outdated
install: | | ||
apt-get update -q -y | ||
apt-get install -q -y python3 automake libtool autotools-dev git make cmake pkg-config gcc wget xz-utils | ||
apt-get install -q -y python3 automake libtool autotools-dev git make cmake pkg-config gcc wget xz-utils libjansson4 libjansson-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apt-get install -q -y python3 automake libtool autotools-dev git make cmake pkg-config gcc wget xz-utils libjansson4 libjansson-dev | |
apt-get install -q -y python3 automake libtool autotools-dev git make cmake pkg-config gcc wget xz-utils libjansson-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wrong, it broke the CI
Signed-off-by: Sourav Moitra <[email protected]>
ca285dc
to
7c67879
Compare
Refers to #138 |
Remove yajl and jansson as gitsubmodule