Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add support for vlan tag and vlan_filtering for bridge driver #146

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Jan 4, 2022

Netavark config allows users to assign VLAN tag and to enable filtering
when using bridge driver.

Users could use --opt flag to specify vlan=id and filtering will we
enabled on the bridge and host end master of bridge will be assigned
respective tag.

Closes: #108

Netavark config allows users to assign VLAN tag and to enable filtering
when using bridge driver.

Users could use `--opt` flag to specify `vlan=id` and filtering will we
enabled on the bridge and host end `master` of bridge will be assigned
respective tag.

Signed-off-by: Aditya Rajan <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 4, 2022
@flouthoc
Copy link
Collaborator Author

flouthoc commented Jan 4, 2022

Wait since this needs upstream: little-dude/netlink#222 which is still under discussion and review.

@flouthoc
Copy link
Collaborator Author

flouthoc commented Jan 4, 2022

CI failures are expected because of missing upstream.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

@flouthoc: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Luap99
Copy link
Member

Luap99 commented Jul 22, 2022

What is going on here?

@flouthoc
Copy link
Collaborator Author

I'll rebase this, my needed patch is already merged and released a while ago.

@Luap99
Copy link
Member

Luap99 commented Jan 24, 2023

@flouthoc friendly reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vlan for bridge
2 participants